Patch fault-injector errors#2652
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 6898b0a | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8087432 ns/iter (± 27851) |
1564816 ns/iter (± 35303) |
5.17 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100_materialise/materialize |
8504766 ns/iter (± 79244) |
1669150 ns/iter (± 10700) |
5.10 |
lotr_graph_window_10/has_node_existing |
141 ns/iter (± 10) |
62 ns/iter (± 11) |
2.27 |
lotr_graph_window_10_materialise/materialize |
3335080 ns/iter (± 26891) |
971980 ns/iter (± 4278) |
3.43 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2004411 ns/iter (± 15556) |
334634 ns/iter (± 1287) |
5.99 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
145 ns/iter (± 9) |
62 ns/iter (± 14) |
2.34 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1209389 ns/iter (± 8461) |
230399 ns/iter (± 2617) |
5.25 |
lotr_graph_window_50_layered/num_edges_temporal |
151022 ns/iter (± 3650) |
70121 ns/iter (± 7586) |
2.15 |
lotr_graph_window_50_layered/has_node_existing |
403 ns/iter (± 23) |
129 ns/iter (± 12) |
3.12 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/max_neighbour_degree |
778376 ns/iter (± 9202) |
386651 ns/iter (± 3853) |
2.01 |
lotr_graph_window_50_layered/graph_latest |
88704 ns/iter (± 2749) |
36649 ns/iter (± 916) |
2.42 |
lotr_graph_window_50_layered_materialise/materialize |
30447338 ns/iter (± 88171) |
3488825 ns/iter (± 24948) |
8.73 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
662229 ns/iter (± 7298) |
192686 ns/iter (± 1569) |
3.44 |
lotr_graph_persistent_window_50_layered/has_node_existing |
452 ns/iter (± 412) |
174 ns/iter (± 83) |
2.60 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
3519967 ns/iter (± 76293) |
1659940 ns/iter (± 19402) |
2.12 |
lotr_graph_persistent_window_50_layered/graph_latest |
147470 ns/iter (± 4595) |
57549 ns/iter (± 4809) |
2.56 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
53219956 ns/iter (± 154777) |
5298035 ns/iter (± 147912) |
10.05 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes all fault-injector/LazyFS bugs that show up on CI.
Quick summary of changes:
sync_allon the.metafile.Configfile.Runningstate.Why are the changes needed?
These changes should fix any durability bugs revealed by LazyFS.
Does this PR introduce any user-facing change? If yes is this documented?
No.
How was this patch tested?
Running the fault-injector CI on pometry-storage: https://github.com/Pometry/pometry-storage/pull/304
Are there any further changes required?
No.